Add MinidumpSimpleStringDictionaryWriter and its test

Add MinidumpSimpleStringDictionaryWriter and its test.

TEST=minidump_test MinidumpSimpleStringDictionaryWriter.*
R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c9db1b1d1922f23068d7fc35d08e58a50f08fe23

[Mark Mentovai, 2014-10-15 21:10:20]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2014-10-16 18:07:59]

https://codereview.chromium.org/656173003/diff/1/minidump/minidump_simple_str...
File minidump/minidump_simple_string_dictionary_writer.cc (right):

https://codereview.chromium.org/656173003/diff/1/minidump/minidump_simple_str...
minidump/minidump_simple_string_dictionary_writer.cc:131: for (const
std::pair<std::string, MinidumpSimpleStringDictionaryEntryWriter*>
This would probably be better written with auto. Same below.

https://codereview.chromium.org/656173003/diff/1/minidump/minidump_simple_str...
minidump/minidump_simple_string_dictionary_writer.cc:132: ke : entries_) {
|ke| ?

https://codereview.chromium.org/656173003/diff/1/minidump/minidump_simple_str...
File minidump/minidump_simple_string_dictionary_writer_test.cc (right):

https://codereview.chromium.org/656173003/diff/1/minidump/minidump_simple_str...
minidump/minidump_simple_string_dictionary_writer_test.cc:54:
reinterpret_cast<const MinidumpUTF8String*>(&file_writer.string()[rva]);
Check if the rva is within bounds first? At the very least, add a warning
comment that caller must check that?

https://codereview.chromium.org/656173003/diff/1/minidump/minidump_simple_str...
minidump/minidump_simple_string_dictionary_writer_test.cc:118: char kKey1[] =
"zzz1";
These are all the same length. May be good to vary that.

[Mark Mentovai, 2014-10-16 19:25:01]

Feedback addressed.

[Robert Sesek, 2014-10-16 21:54:18]

LGTM

[Mark Mentovai, 2014-10-16 22:09:22]

Committed patchset #2 (id:20001) manually as
c9db1b1d1922f23068d7fc35d08e58a50f08fe23 (presubmit successful).