Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: minidump/minidump_string_writer_test.cc

Issue 656173003: Add MinidumpSimpleStringDictionaryWriter and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_string_writer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 {8, "o\303\263\303\266\305\221o"}, 174 {8, "o\303\263\303\266\305\221o"},
175 {4, "\360\220\204\202"}, // 𐄂 (non-BMP) 175 {4, "\360\220\204\202"}, // 𐄂 (non-BMP)
176 }; 176 };
177 177
178 for (size_t index = 0; index < arraysize(kTestData); ++index) { 178 for (size_t index = 0; index < arraysize(kTestData); ++index) {
179 SCOPED_TRACE(base::StringPrintf( 179 SCOPED_TRACE(base::StringPrintf(
180 "index %zu, input %s", index, kTestData[index].string)); 180 "index %zu, input %s", index, kTestData[index].string));
181 181
182 file_writer.Reset(); 182 file_writer.Reset();
183 crashpad::internal::MinidumpUTF8StringWriter string_writer; 183 crashpad::internal::MinidumpUTF8StringWriter string_writer;
184 string_writer.SetUTF8( 184 std::string test_string(kTestData[index].string, kTestData[index].length);
185 std::string(kTestData[index].string, kTestData[index].length)); 185 string_writer.SetUTF8(test_string);
186 EXPECT_EQ(test_string, string_writer.UTF8());
186 EXPECT_TRUE(string_writer.WriteEverything(&file_writer)); 187 EXPECT_TRUE(string_writer.WriteEverything(&file_writer));
187 188
188 const size_t expected_utf8_bytes_with_nul = kTestData[index].length + 1; 189 const size_t expected_utf8_bytes_with_nul = kTestData[index].length + 1;
189 ASSERT_EQ(sizeof(MinidumpUTF8String) + expected_utf8_bytes_with_nul, 190 ASSERT_EQ(sizeof(MinidumpUTF8String) + expected_utf8_bytes_with_nul,
190 file_writer.string().size()); 191 file_writer.string().size());
191 const MinidumpUTF8String* minidump_string = 192 const MinidumpUTF8String* minidump_string =
192 MinidumpUTF8StringCast(file_writer); 193 MinidumpUTF8StringCast(file_writer);
193 EXPECT_EQ(kTestData[index].length, minidump_string->Length); 194 EXPECT_EQ(kTestData[index].length, minidump_string->Length);
194 EXPECT_EQ(0, 195 EXPECT_EQ(0,
195 memcmp(kTestData[index].string, 196 memcmp(kTestData[index].string,
196 minidump_string->Buffer, 197 minidump_string->Buffer,
197 expected_utf8_bytes_with_nul)); 198 expected_utf8_bytes_with_nul));
198 } 199 }
199 } 200 }
200 201
201 } // namespace 202 } // namespace
202 } // namespace test 203 } // namespace test
203 } // namespace crashpad 204 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_string_writer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698