Issue 656143004: Remove (untested) code for unsupported compilers.

Issue 656143004: Remove (untested) code for unsupported compilers. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer

Modified:
6 years, 2 months ago

Reviewers:
Sven Panne

CC:
Paweł Hajdan Jr., v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove (untested) code for unsupported compilers. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24735

Patch Set 3 : Fix comment. #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -211 lines)			Patch
M	BUILD.gn	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	include/v8config.h	View	1 2	5 chunks	+6 lines, -7 lines	0 comments	Download
M	src/base/compiler-specific.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/base/platform/platform.h	View		3 chunks	+2 lines, -32 lines	0 comments	Download
M	src/base/platform/platform-win32.cc	View	1	4 chunks	+1 line, -17 lines	0 comments	Download
D	src/base/win32-math.h	View		1 chunk	+0 lines, -42 lines	0 comments	Download
D	src/base/win32-math.cc	View		1 chunk	+0 lines, -82 lines	0 comments	Download
M	src/preparser.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/utils.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/cctest.cc	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	test/cctest/test-log-stack-tracer.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit. Node code is good code! :-) https://codereview.chromium.org/656143004/diff/20001/include/v8config.h File include/v8config.h (right): https://codereview.chromium.org/656143004/diff/20001/include/v8config.h#newcode283 ...

6 years, 2 months ago (2014-10-20 12:02:13 UTC) #2

Benedikt Meurer

https://codereview.chromium.org/656143004/diff/20001/include/v8config.h File include/v8config.h (right): https://codereview.chromium.org/656143004/diff/20001/include/v8config.h#newcode283 include/v8config.h:283: // Visual Studio 2010 and earlier spell "final" as ...

6 years, 2 months ago (2014-10-20 12:03:20 UTC) #3

Benedikt Meurer

6 years, 2 months ago (2014-10-20 12:04:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 24735 (presubmit successful).

Expand Messages | Collapse Messages