Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: Source/core/dom/PendingScript.cpp

Issue 656113002: Refactor Script(Loader|Runner): don't access Resources all over the place... (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: code review (haraken) Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/PendingScript.cpp
diff --git a/Source/core/dom/PendingScript.cpp b/Source/core/dom/PendingScript.cpp
index 143e6680b7c9f92eb4a9087fd54e9b2a75240e34..a3601a960d17c1cecec68ce2bb2e77bf44715148 100644
--- a/Source/core/dom/PendingScript.cpp
+++ b/Source/core/dom/PendingScript.cpp
@@ -40,13 +40,12 @@ PendingScript::~PendingScript()
void PendingScript::watchForLoad(ScriptResourceClient* client)
{
ASSERT(!m_watchingForLoad);
- ASSERT(!isReady());
+ // addClient() will call notifyFinished() if the load is complete. Callers
+ // who do not expect to be re-entered from this call should not call
+ // watchForLoad for a PendingScript which isReady.
if (m_streamer) {
m_streamer->addClient(client);
} else {
- // addClient() will call notifyFinished() if the load is
- // complete. Callers do not expect to be re-entered from this call, so
- // they should not become a client of an already-loaded Resource.
resource()->addClient(client);
}
m_watchingForLoad = true;

Powered by Google App Engine
This is Rietveld 408576698