Source/bindings/core/v8/ScriptStreamer.h - Issue 656113002: Refactor Script(Loader|Runner): don't access Resources all over the place...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptStreamer.h

Issue 656113002: Refactor Script(Loader|Runner): don't access Resources all over the place... (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: code review (haraken) Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/ScriptStreamer.h

diff --git a/Source/bindings/core/v8/ScriptStreamer.h b/Source/bindings/core/v8/ScriptStreamer.h

index 78fa1cbc7e2a387bc835345646d88e676ebe6160..5dea593eb1ebede3051c3bf762e39a2f50496cdd 100644

--- a/Source/bindings/core/v8/ScriptStreamer.h

+++ b/Source/bindings/core/v8/ScriptStreamer.h

@@ -66,8 +66,8 @@ public:

void addClient(ScriptResourceClient* client)

{

ASSERT(!m_client);

- ASSERT(!isFinished());

m_client = client;

+ notifyFinishedToClient();

}

void removeClient(ScriptResourceClient* client)

« no previous file with comments | « no previous file | Source/core/dom/PendingScript.cpp » ('j') | Source/core/dom/ScriptLoader.h » ('J')