tools/gn/functions_unittest.cc - Issue 656093004: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/functions_unittest.cc

Issue 656093004: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/functions_unittest.cc

diff --git a/tools/gn/functions_unittest.cc b/tools/gn/functions_unittest.cc

index 3f6a6a9bea69b64ea3810e8c6cccce59ce29b925..e506b6874b6dbee2c24e96db54fa622d67878d64 100644

--- a/tools/gn/functions_unittest.cc

+++ b/tools/gn/functions_unittest.cc

@@ -47,7 +47,7 @@ TEST(Functions, Defined) {

undef_accessor->set_member(scoped_ptr<IdentifierNode>(

new IdentifierNode(undefined_token)));

ListNode args_list_accessor_defined;

- args_list_accessor_defined.append_item(undef_accessor.PassAs<ParseNode>());

+ args_list_accessor_defined.append_item(undef_accessor.Pass());

result = functions::RunDefined(setup.scope(), &function_call,

&args_list_accessor_defined, &err);

ASSERT_EQ(Value::BOOLEAN, result.type());

« no previous file with comments | « no previous file | tools/gn/operators_unittest.cc » ('j') | no next file with comments »