tools/gn/functions_unittest.cc - Issue 656093004: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/gn/functions_unittest.cc

Issue 656093004: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | tools/gn/operators_unittest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "testing/gtest/include/gtest/gtest.h"	5 #include "testing/gtest/include/gtest/gtest.h"

6 #include "tools/gn/functions.h"	6 #include "tools/gn/functions.h"

7 #include "tools/gn/parse_tree.h"	7 #include "tools/gn/parse_tree.h"

8 #include "tools/gn/test_with_scope.h"	8 #include "tools/gn/test_with_scope.h"

9 #include "tools/gn/value.h"	9 #include "tools/gn/value.h"

10	10

(...skipping 29 matching lines...) Expand all Loading...
40 ASSERT_EQ(Value::BOOLEAN, result.type());	40 ASSERT_EQ(Value::BOOLEAN, result.type());

41 EXPECT_TRUE(result.boolean_value());	41 EXPECT_TRUE(result.boolean_value());

42	42

43 // Should also work by passing an accessor node so you can do	43 // Should also work by passing an accessor node so you can do

44 // "defined(def.foo)" to see if foo is defined on the def scope.	44 // "defined(def.foo)" to see if foo is defined on the def scope.

45 scoped_ptr<AccessorNode> undef_accessor(new AccessorNode);	45 scoped_ptr<AccessorNode> undef_accessor(new AccessorNode);

46 undef_accessor->set_base(defined_token);	46 undef_accessor->set_base(defined_token);

47 undef_accessor->set_member(scoped_ptr<IdentifierNode>(	47 undef_accessor->set_member(scoped_ptr<IdentifierNode>(

48 new IdentifierNode(undefined_token)));	48 new IdentifierNode(undefined_token)));

49 ListNode args_list_accessor_defined;	49 ListNode args_list_accessor_defined;

50 args_list_accessor_defined.append_item(undef_accessor.PassAs<ParseNode>());	50 args_list_accessor_defined.append_item(undef_accessor.Pass());

51 result = functions::RunDefined(setup.scope(), &function_call,	51 result = functions::RunDefined(setup.scope(), &function_call,

52 &args_list_accessor_defined, &err);	52 &args_list_accessor_defined, &err);

53 ASSERT_EQ(Value::BOOLEAN, result.type());	53 ASSERT_EQ(Value::BOOLEAN, result.type());

54 EXPECT_FALSE(result.boolean_value());	54 EXPECT_FALSE(result.boolean_value());

55 }	55 }

OLD	NEW