Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: Source/bindings/templates/dictionary_v8.h

Issue 656073002: IDL: Use ALLOW_ONLY_INLINE_ALLOCATION() in dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/dictionary_impl.h ('k') | Source/bindings/templates/dictionary_v8.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/dictionary_v8.h
diff --git a/Source/bindings/templates/dictionary_v8.h b/Source/bindings/templates/dictionary_v8.h
index a14f2bf79555c3516de17c697870c154ed588558..fb751e3ba1de53a27cf1b11e5f263c0054018279 100644
--- a/Source/bindings/templates/dictionary_v8.h
+++ b/Source/bindings/templates/dictionary_v8.h
@@ -17,13 +17,13 @@ class ExceptionState;
class {{v8_class}} {
public:
- static {{cpp_class}}* toImpl(v8::Isolate*, v8::Handle<v8::Value>, ExceptionState&);
+ static void toImpl(v8::Isolate*, v8::Handle<v8::Value>, {{cpp_class}}&, ExceptionState&);
};
-v8::Handle<v8::Value> toV8({{cpp_class}}*, v8::Handle<v8::Object>, v8::Isolate*);
+v8::Handle<v8::Value> toV8({{cpp_class}}&, v8::Handle<v8::Object>, v8::Isolate*);
template<class CallbackInfo>
-inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{cpp_class}}* impl)
+inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{cpp_class}}& impl)
{
v8SetReturnValue(callbackInfo, toV8(impl, callbackInfo.Holder(), callbackInfo.GetIsolate()));
}
« no previous file with comments | « Source/bindings/templates/dictionary_impl.h ('k') | Source/bindings/templates/dictionary_v8.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698