Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: Source/bindings/templates/dictionary_impl.h

Issue 656073002: IDL: Use ALLOW_ONLY_INLINE_ALLOCATION() in dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/templates/dictionary_v8.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/dictionary_impl.h
diff --git a/Source/bindings/templates/dictionary_impl.h b/Source/bindings/templates/dictionary_impl.h
index 3cc7bcdb5e67035d094174520a21351e2ecc7e24..9cdea3d4cc10829e56e1fd4f85028554847dfb02 100644
--- a/Source/bindings/templates/dictionary_impl.h
+++ b/Source/bindings/templates/dictionary_impl.h
@@ -13,24 +13,20 @@
namespace blink {
-class {{cpp_class}} final : public GarbageCollectedFinalized<{{cpp_class}}> {
+class {{cpp_class}} final {
+ ALLOW_ONLY_INLINE_ALLOCATION();
public:
- static {{cpp_class}}* create()
- {
- return new {{cpp_class}};
- }
+ {{cpp_class}}();
{% for member in members %}
bool {{member.has_method_name}}() const { return {{member.has_method_expression}}; }
{{member.rvalue_cpp_type}} {{member.cpp_name}}() const { return {{member.getter_expression}}; }
void {{member.setter_name}}({{member.rvalue_cpp_type}} value) { m_{{member.cpp_name}} = value; }
- {% endfor %}
+ {% endfor %}
void trace(Visitor*);
private:
- {{cpp_class}}();
-
{% for member in members %}
{{member.member_cpp_type}} m_{{member.cpp_name}};
{% endfor %}
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/templates/dictionary_v8.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698