Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp - Issue 656073002: IDL: Use ALLOW_ONLY_INLINE_ALLOCATION() in dictionaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

Issue 656073002: IDL: Use ALLOW_ONLY_INLINE_ALLOCATION() in dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/methods.cpp ('K') | « Source/modules/serviceworkers/ServiceWorkerClientQueryOptions.idl ('k') | Source/modules/webmidi/MIDIOptions.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

diff --git a/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp b/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

index cb40ef5f112f6427af65772cf27f8cb80b9915a4..04f0433e8f460e28853f1c22e537e34a4b78bfb9 100644

--- a/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

+++ b/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

@@ -177,9 +177,9 @@ protected:

ServiceWorkerContainer* container = ServiceWorkerContainer::create(executionContext());

ScriptState::Scope scriptScope(scriptState());

- RegistrationOptions* options = RegistrationOptions::create();

- options->setScope(scope);

- ScriptPromise promise = container->registerServiceWorker(scriptState(), scriptURL, *options);

+ RegistrationOptions options;

+ options.setScope(scope);

+ ScriptPromise promise = container->registerServiceWorker(scriptState(), scriptURL, options);

expectRejected(scriptState(), promise, valueTest);

container->willBeDetachedFromFrame();

@@ -318,9 +318,9 @@ TEST_F(ServiceWorkerContainerTest, RegisterUnregister_NonHttpsSecureOriginDelega

// register

{

ScriptState::Scope scriptScope(scriptState());

- RegistrationOptions* options = RegistrationOptions::create();

- options->setScope("y/");

- container->registerServiceWorker(scriptState(), "/z/worker.js", *options);

+ RegistrationOptions options;

+ options.setScope("y/");

+ container->registerServiceWorker(scriptState(), "/z/worker.js", options);

EXPECT_EQ(1ul, stubProvider.registerCallCount());

EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/x/y/")), stubProvider.registerScope());