Source/bindings/templates/methods.cpp - Issue 656073002: IDL: Use ALLOW_ONLY_INLINE_ALLOCATION() in dictionaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/methods.cpp

Issue 656073002: IDL: Use ALLOW_ONLY_INLINE_ALLOCATION() in dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/dictionary_v8.cpp ('K') | « Source/bindings/templates/dictionary_v8.cpp ('k') | Source/bindings/tests/idls/core/TestDictionary.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/templates/methods.cpp

diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp

index 94b70730869b707916dfc76315938738c13565d4..c95b8329e114654dbe0b69bcf0c6a897b54032f9 100644

--- a/Source/bindings/templates/methods.cpp

+++ b/Source/bindings/templates/methods.cpp

@@ -233,6 +233,9 @@ Document& document = *toDocument(currentExecutionContext(info.GetIsolate()));

{{method.cpp_type}} result{{method.cpp_type_initializer}};

if (!{{method.cpp_value}})

return;

+{% elif method.use_argument_for_return_value %}

+{{method.cpp_type}} cppValue;

haraken 2014/10/15 14:38:29 I'd rename |cppValue| to |result| for consistency

bashi 2014/10/17 00:50:05 Done.

+{{cpp_value}};

{% elif method.is_constructor %}

{{method.cpp_type}} impl = {{cpp_value}};

{% elif method.use_local_result and not method.union_arguments %}