Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 655913003: Use texture strip atlas for color table filter (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 1 month ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : working #

Patch Set 3 : fix #

Total comments: 2

Patch Set 4 : fix include order #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -29 lines) Patch
M src/effects/SkTableColorFilter.cpp View 1 2 3 7 chunks +113 lines, -24 lines 1 comment Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bsalomon
This doesn't really help the N10 memory usage significantly, but it does improve the desk_carsvg ...
6 years, 1 month ago (2014-10-27 18:24:36 UTC) #2
robertphillips
lgtm + nit https://codereview.chromium.org/655913003/diff/40001/src/effects/SkTableColorFilter.cpp File src/effects/SkTableColorFilter.cpp (right): https://codereview.chromium.org/655913003/diff/40001/src/effects/SkTableColorFilter.cpp#newcode282 src/effects/SkTableColorFilter.cpp:282: #include "gl/builders/GrGLProgramBuilder.h" move to before gl ...
6 years, 1 month ago (2014-10-27 19:35:06 UTC) #3
bsalomon
https://codereview.chromium.org/655913003/diff/40001/src/effects/SkTableColorFilter.cpp File src/effects/SkTableColorFilter.cpp (right): https://codereview.chromium.org/655913003/diff/40001/src/effects/SkTableColorFilter.cpp#newcode282 src/effects/SkTableColorFilter.cpp:282: #include "gl/builders/GrGLProgramBuilder.h" On 2014/10/27 19:35:06, robertphillips wrote: > move ...
6 years, 1 month ago (2014-10-27 19:43:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655913003/60001
6 years, 1 month ago (2014-10-27 19:44:43 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001) as c6327a8f7e7e282c0b3a95049c75db7a8f92c693
6 years, 1 month ago (2014-10-27 19:53:12 UTC) #7
reed1
6 years, 1 month ago (2014-10-28 13:42:42 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/655913003/diff/60001/src/effects/SkTableColor...
File src/effects/SkTableColorFilter.cpp (right):

https://codereview.chromium.org/655913003/diff/60001/src/effects/SkTableColor...
src/effects/SkTableColorFilter.cpp:281: #include "effects/GrTextureStripAtlas.h"
do we need to qualify this header's path? We don't seem to do that in other
places.

Powered by Google App Engine
This is Rietveld 408576698