Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 655723003: [Android] Don't use zip pushing if not built or on user builds. (Closed)

Created:
6 years, 2 months ago by jbudorick
Modified:
6 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Don't use zip pushing if not built or on user builds. BUG=422995, 423026 Committed: https://crrev.com/16e91399723076cc0c5cf8a5348efd1952e84198 Cr-Commit-Position: refs/heads/master@{#299663}

Patch Set 1 #

Patch Set 2 : additional gyp dependencies #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -17 lines) Patch
M build/all.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M build/android/pylib/device/commands/install_commands.py View 1 2 3 2 chunks +13 lines, -5 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 1 2 8 chunks +38 lines, -10 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 2 chunks +17 lines, -2 lines 0 comments Download
M build/java_apk.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M build/uiautomator_test.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/forwarder2/forwarder.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
jbudorick
This CL makes 'unzip' being unavailable nonfatal; instead, we just fall back to using the ...
6 years, 2 months ago (2014-10-14 09:19:42 UTC) #2
jbudorick
Note that the current version of this CL is liable to cause 423025 to happen ...
6 years, 2 months ago (2014-10-14 10:16:05 UTC) #3
klundberg
lgtm
6 years, 2 months ago (2014-10-14 18:28:20 UTC) #4
jbudorick
https://codereview.chromium.org/655723003/diff/40001/build/android/pylib/device/commands/install_commands.py File build/android/pylib/device/commands/install_commands.py (right): https://codereview.chromium.org/655723003/diff/40001/build/android/pylib/device/commands/install_commands.py#newcode29 build/android/pylib/device/commands/install_commands.py:29: if not device.IsUserBuild(): need to remove the not here, ...
6 years, 2 months ago (2014-10-14 18:28:49 UTC) #5
xhwang
I hit the same bug and this CL seems to fix the issue for me!
6 years, 2 months ago (2014-10-14 19:09:42 UTC) #7
cjhopman
lgtm
6 years, 2 months ago (2014-10-14 20:47:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655723003/60001
6 years, 2 months ago (2014-10-15 07:40:55 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-15 08:24:21 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 08:25:29 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/16e91399723076cc0c5cf8a5348efd1952e84198
Cr-Commit-Position: refs/heads/master@{#299663}

Powered by Google App Engine
This is Rietveld 408576698