Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Side by Side Diff: build/android/pylib/device/commands/install_commands.py

Issue 655723003: [Android] Don't use zip pushing if not built or on user builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/all.gyp ('k') | build/android/pylib/device/device_utils.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 6
7 from pylib import constants 7 from pylib import constants
8 8
9 BIN_DIR = '%s/bin' % constants.TEST_EXECUTABLE_DIR 9 BIN_DIR = '%s/bin' % constants.TEST_EXECUTABLE_DIR
10 _FRAMEWORK_DIR = '%s/framework' % constants.TEST_EXECUTABLE_DIR 10 _FRAMEWORK_DIR = '%s/framework' % constants.TEST_EXECUTABLE_DIR
11 11
12 _COMMANDS = { 12 _COMMANDS = {
13 'unzip': 'org.chromium.android.commands.unzip.Unzip', 13 'unzip': 'org.chromium.android.commands.unzip.Unzip',
14 } 14 }
15 15
16 _SHELL_COMMAND_FORMAT = ( 16 _SHELL_COMMAND_FORMAT = (
17 """#!/system/bin/sh 17 """#!/system/bin/sh
18 base=%s 18 base=%s
19 export CLASSPATH=$base/framework/chromium_commands.jar 19 export CLASSPATH=$base/framework/chromium_commands.jar
20 exec app_process $base/bin %s $@ 20 exec app_process $base/bin %s $@
21 """) 21 """)
22 22
23 23
24 def Installed(device): 24 def Installed(device):
25 return all(device.FileExists('%s/%s' % (BIN_DIR, c)) for c in _COMMANDS) 25 return (all(device.FileExists('%s/%s' % (BIN_DIR, c)) for c in _COMMANDS)
26 26 and device.FileExists('%s/chromium_commands.jar' % _FRAMEWORK_DIR))
27 27
28 def InstallCommands(device): 28 def InstallCommands(device):
29 if device.IsUserBuild():
30 raise Exception('chromium_commands currently requires a userdebug build.')
31
32 chromium_commands_jar_path = os.path.join(
33 constants.GetOutDirectory(), constants.SDK_BUILD_JAVALIB_DIR,
34 'chromium_commands.dex.jar')
35 if not os.path.exists(chromium_commands_jar_path):
36 raise Exception('%s not found. Please build chromium_commands.'
37 % chromium_commands_jar_path)
38
29 device.RunShellCommand(['mkdir', BIN_DIR, _FRAMEWORK_DIR]) 39 device.RunShellCommand(['mkdir', BIN_DIR, _FRAMEWORK_DIR])
30 for command, main_class in _COMMANDS.iteritems(): 40 for command, main_class in _COMMANDS.iteritems():
31 shell_command = _SHELL_COMMAND_FORMAT % ( 41 shell_command = _SHELL_COMMAND_FORMAT % (
32 constants.TEST_EXECUTABLE_DIR, main_class) 42 constants.TEST_EXECUTABLE_DIR, main_class)
33 shell_file = '%s/%s' % (BIN_DIR, command) 43 shell_file = '%s/%s' % (BIN_DIR, command)
34 device.WriteTextFile(shell_file, shell_command) 44 device.WriteTextFile(shell_file, shell_command)
35 device.RunShellCommand( 45 device.RunShellCommand(
36 ['chmod', '755', shell_file], check_return=True) 46 ['chmod', '755', shell_file], check_return=True)
37 47
38 device.adb.Push( 48 device.adb.Push(
39 os.path.join(constants.GetOutDirectory(), 49 chromium_commands_jar_path,
40 constants.SDK_BUILD_JAVALIB_DIR,
41 'chromium_commands.dex.jar'),
42 '%s/chromium_commands.jar' % _FRAMEWORK_DIR) 50 '%s/chromium_commands.jar' % _FRAMEWORK_DIR)
43 51
OLDNEW
« no previous file with comments | « build/all.gyp ('k') | build/android/pylib/device/device_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698