Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 655693003: remove obsolete OVERRIDE/FINAL presubmit checks (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove obsolete OVERRIDE/FINAL presubmit checks BUG=417463 Committed: https://crrev.com/5a73a5d37237fcf25bb05571a314193188600c65 Cr-Commit-Position: refs/heads/master@{#300675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -77 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -17 lines 0 comments Download
M PRESUBMIT_test.py View 1 chunk +0 lines, -60 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Mostyn Bramley-Moore
@Mike, M-A, MRV: now that the OVERRIDE and FINAL macros have been removed, we no ...
6 years, 2 months ago (2014-10-22 09:43:55 UTC) #2
Mike West
Right. A compile failure should be enough warning for developers. :) LGTM, but please wait ...
6 years, 2 months ago (2014-10-22 10:18:50 UTC) #4
Mostyn Bramley-Moore
Adding Darin for OWNER approval...
6 years, 2 months ago (2014-10-22 10:26:03 UTC) #6
Mike West
On 2014/10/22 10:26:03, Mostyn Bramley-Moore wrote: > Adding Darin for OWNER approval... Jochen or Maurel ...
6 years, 2 months ago (2014-10-22 11:13:24 UTC) #7
Mostyn Bramley-Moore
On 2014/10/22 11:13:24, Mike West wrote: > On 2014/10/22 10:26:03, Mostyn Bramley-Moore wrote: > > ...
6 years, 2 months ago (2014-10-22 11:58:42 UTC) #9
M-A Ruel
lgtm
6 years, 2 months ago (2014-10-22 12:34:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655693003/1
6 years, 2 months ago (2014-10-22 12:35:34 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 13:21:36 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 13:22:22 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a73a5d37237fcf25bb05571a314193188600c65
Cr-Commit-Position: refs/heads/master@{#300675}

Powered by Google App Engine
This is Rietveld 408576698