Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: PRESUBMIT.py

Issue 655693003: remove obsolete OVERRIDE/FINAL presubmit checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 6ee3db6eae7dfb58483a95295b9ffb2de51ed599..3d2d077e5f07cfdc470dc42509109bbb5f532204 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1282,22 +1282,6 @@ def _CheckNoDeprecatedJS(input_api, output_api):
return results
-def _CheckForOverrideAndFinalRules(input_api, output_api):
- """Checks for final and override used as per C++11"""
- problems = []
- for f in input_api.AffectedFiles():
- if (f.LocalPath().endswith(('.cc', '.cpp', '.h', '.mm'))):
- for line_num, line in f.ChangedContents():
- if (input_api.re.search(r'\b(FINAL|OVERRIDE)\b', line)):
- problems.append(' %s:%d' % (f.LocalPath(), line_num))
-
- if not problems:
- return []
- return [output_api.PresubmitError('Use C++11\'s |final| and |override| '
- 'rather than FINAL and OVERRIDE.',
- problems)]
-
-
def _CommonChecks(input_api, output_api):
"""Checks common to both upload and commit."""
results = []
@@ -1340,7 +1324,6 @@ def _CommonChecks(input_api, output_api):
results.extend(_CheckNoDeprecatedJS(input_api, output_api))
results.extend(_CheckParseErrors(input_api, output_api))
results.extend(_CheckForIPCRules(input_api, output_api))
- results.extend(_CheckForOverrideAndFinalRules(input_api, output_api))
if any('PRESUBMIT.py' == f.LocalPath() for f in input_api.AffectedFiles()):
results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698