Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 655413002: Convert ARRAYSIZE_UNSAFE -> arraysize in chrome/browser/. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, asanka, vandebo (ex-Chrome), aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, tzik, posciak+watch_chromium.org, browser-components-watch_chromium.org, yukishiino+watch_chromium.org, dmazzoni+watch_chromium.org, stevenjb+watch_chromium.org, mkwst+watchlist_chromium.org, yusukes+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, shishir+watch_chromium.org, benjhayden+dwatch_chromium.org, Ilya Sherman, nona+watch_chromium.org, gab+watch_chromium.org, jkarlin+watch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, dtseng+watch_chromium.org, tburkard+watch_chromium.org, rouslan+spellwatch_chromium.org, nhiroki, rlp+watch_chromium.org, feature-media-reviews_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, gcasto+watchlist_chromium.org, davidben+watch_chromium.org, plundblad+watch_chromium.org, gavinp+prer_chromium.org, Lei Zhang, tfarina, mcasas+watch_chromium.org, robertshield+watch_chromium.org, asvitkine+watch_chromium.org, tommycli, davemoore+watch_chromium.org, Greg Billock, James Su, wjia+watch_chromium.org, kinuko+fileapi, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert ARRAYSIZE_UNSAFE -> arraysize in chrome/browser/. R=thestig@chromium.org BUG=423134 Committed: https://crrev.com/9e65ad1307b537eac9ddc568d8afd88549c1443c Cr-Commit-Position: refs/heads/master@{#299837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -171 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/bookmark_provider_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 27 chunks +30 lines, -30 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_encoding_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_plugin_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/change_list_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/events/keyboard_driven_event_rewriter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_item_model_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/socket/udp_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/global_keyboard_shortcuts_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/global_keyboard_shortcuts_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_querying_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/in_memory_url_index_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/top_sites_cache_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/url_utils_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/locale_tests_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/linux/mtp_device_object_enumerator_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_permissions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_object_enumerator_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/jtl_interpreter_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_linux_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_global_error_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/task_manager_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/stacked_tab_strip_layout_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
viettrungluu
6 years, 2 months ago (2014-10-16 02:54:04 UTC) #1
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-16 03:01:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655413002/1
6 years, 2 months ago (2014-10-16 03:03:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 04:22:36 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 04:23:20 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9e65ad1307b537eac9ddc568d8afd88549c1443c
Cr-Commit-Position: refs/heads/master@{#299837}

Powered by Google App Engine
This is Rietveld 408576698