chrome/browser/prefs/chrome_pref_service_factory.cc - Issue 655413002: Convert ARRAYSIZE_UNSAFE -> arraysize in chrome/browser/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/chrome_pref_service_factory.cc

Issue 655413002: Convert ARRAYSIZE_UNSAFE -> arraysize in chrome/browser/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/predictors/autocomplete_action_predictor_unittest.cc ('k') | chrome/browser/prerender/prerender_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/chrome_pref_service_factory.cc

diff --git a/chrome/browser/prefs/chrome_pref_service_factory.cc b/chrome/browser/prefs/chrome_pref_service_factory.cc

index 4104f0e6693ba141f0a3ec40853da7d4a05af9a3..4f66ad20a140fad027eead28ee7964a27eec7814 100644

--- a/chrome/browser/prefs/chrome_pref_service_factory.cc

+++ b/chrome/browser/prefs/chrome_pref_service_factory.cc

@@ -252,11 +252,7 @@ SettingsEnforcementGroup GetSettingsEnforcementGroup() {

chrome_prefs::internals::kSettingsEnforcementTrialName);

if (trial) {

const std::string& group_name = trial->group_name();

- // ARRAYSIZE_UNSAFE must be used since the array is declared locally; it is

- // only unsafe because it could not trigger a compile error on some

- // non-array pointer types; this is fine since kEnforcementLevelMap is

- // clearly an array.

- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kEnforcementLevelMap); ++i) {

+ for (size_t i = 0; i < arraysize(kEnforcementLevelMap); ++i) {

if (kEnforcementLevelMap[i].group_name == group_name) {

enforcement_group = kEnforcementLevelMap[i].group;

group_determined_from_trial = true;