Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 655373002: [chromedriver] Accept <webview> tags in chromedriver (Closed)

Created:
6 years, 2 months ago by samuong
Modified:
6 years, 2 months ago
Reviewers:
stgao
CC:
chromium-reviews, vsevik, samuong+watch_chromium.org, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, stgao, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Accept <webview> tags in chromedriver BUG=chromedriver:916 Committed: https://crrev.com/5dc7274c4f33b0609cfe0162492038a649fcb899 Cr-Commit-Position: refs/heads/master@{#299816}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M chrome/test/chromedriver/chrome/chrome_impl.cc View 1 chunk +0 lines, -9 lines 1 comment Download
M chrome/test/chromedriver/chrome/devtools_http_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome/devtools_http_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
samuong
6 years, 2 months ago (2014-10-15 23:50:35 UTC) #2
stgao
lgtm with nit. https://codereview.chromium.org/655373002/diff/1/chrome/test/chromedriver/chrome/chrome_impl.cc File chrome/test/chromedriver/chrome/chrome_impl.cc (right): https://codereview.chromium.org/655373002/diff/1/chrome/test/chromedriver/chrome/chrome_impl.cc#newcode55 chrome/test/chromedriver/chrome/chrome_impl.cc:55: if (view.type != WebViewInfo::kPage && view.type ...
6 years, 2 months ago (2014-10-16 00:00:11 UTC) #3
samuong
On 2014/10/16 00:00:11, Shuotao wrote: > lgtm with nit. > > https://codereview.chromium.org/655373002/diff/1/chrome/test/chromedriver/chrome/chrome_impl.cc > File chrome/test/chromedriver/chrome/chrome_impl.cc ...
6 years, 2 months ago (2014-10-16 00:03:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655373002/1
6 years, 2 months ago (2014-10-16 00:04:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 01:59:47 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 02:00:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5dc7274c4f33b0609cfe0162492038a649fcb899
Cr-Commit-Position: refs/heads/master@{#299816}

Powered by Google App Engine
This is Rietveld 408576698