Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7551)

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.cc

Issue 655373002: [chromedriver] Accept <webview> tags in chromedriver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome/devtools_http_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/chrome_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_impl.cc b/chrome/test/chromedriver/chrome/chrome_impl.cc
index 47dc392fafc359d124572ac01d8774e01182533d..fc332d0b11dc5fbf5cff6fbc0ed24136ab45b0a4 100644
--- a/chrome/test/chromedriver/chrome/chrome_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_impl.cc
@@ -55,15 +55,6 @@ Status ChromeImpl::GetWebViewIds(std::list<std::string>* web_view_ids) {
if (view.type != WebViewInfo::kPage && view.type != WebViewInfo::kApp)
stgao 2014/10/16 00:00:11 If we want to support switching to a webview tab,
continue;
- // Workaround to ignore generated background pages that are
- // being returned as active windows for some builds of Chrome.
- // TODO(bustamante): Once Chrome builds < 1755 are no longer
- // supported this check can be removed.
- int kBuildNumber = devtools_http_client_->browser_info()->build_no;
- if (kBuildNumber < 1755 && view.type == WebViewInfo::kApp &&
- view.url.find("_generated_background") != std::string::npos)
- continue;
-
bool found = false;
for (WebViewList::const_iterator web_view_iter = web_views_.begin();
web_view_iter != web_views_.end(); ++web_view_iter) {
« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome/devtools_http_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698