extensions/renderer/extension_helper.h - Issue 655273005: Implement AutomationNode.querySelector().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/extension_helper.h

Issue 655273005: Implement AutomationNode.querySelector(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix heap-use-after-free issue by not keeping a scoped_ptr to automation_api_helper in extension_hel… Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/extension_helper.h

diff --git a/extensions/renderer/extension_helper.h b/extensions/renderer/extension_helper.h

index 7e660757d6d1c0eeab281efe3bef3b254d5333cb..9a041425deefd62807bcef690341c789bd03c847 100644

--- a/extensions/renderer/extension_helper.h

+++ b/extensions/renderer/extension_helper.h

@@ -7,6 +7,7 @@

#include <vector>

+#include "base/memory/scoped_ptr.h"

#include "content/public/common/console_message_level.h"

#include "content/public/renderer/render_view_observer.h"

#include "content/public/renderer/render_view_observer_tracker.h"

@@ -22,7 +23,9 @@ class ListValue;

}

namespace extensions {

+class AutomationApiHelper;

class Dispatcher;

struct Message;

// RenderView-level plumbing for extension features.