extensions/renderer/extension_helper.cc - Issue 655273005: Implement AutomationNode.querySelector().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/extension_helper.cc

Issue 655273005: Implement AutomationNode.querySelector(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix heap-use-after-free issue by not keeping a scoped_ptr to automation_api_helper in extension_hel… Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/extension_helper.cc

diff --git a/extensions/renderer/extension_helper.cc b/extensions/renderer/extension_helper.cc

index f12b526e2d95de3764af5a8044b94c728f4990ae..fef086948a3e113184db846b7f40a7f2e82e0f33 100644

--- a/extensions/renderer/extension_helper.cc

+++ b/extensions/renderer/extension_helper.cc

@@ -9,6 +9,7 @@

#include "extensions/common/api/messaging/message.h"

#include "extensions/common/constants.h"

#include "extensions/common/extension_messages.h"

+#include "extensions/renderer/api/automation/automation_api_helper.h"

#include "extensions/renderer/console.h"

#include "extensions/renderer/dispatcher.h"

#include "extensions/renderer/messaging_bindings.h"

@@ -122,6 +123,8 @@ ExtensionHelper::ExtensionHelper(content::RenderView* render_view,

view_type_(VIEW_TYPE_INVALID),

tab_id_(-1),

browser_window_id_(-1) {

+ // Lifecycle managed by RenderViewObserver.

+ new AutomationApiHelper(render_view);

}

ExtensionHelper::~ExtensionHelper() {

« no previous file with comments | « extensions/renderer/extension_helper.h ('k') | no next file » | no next file with comments »