Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 655263005: Build gpu stats tracking in dev builds. (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Build gpu stats tracking in dev builds. Fix cache stats, add more info. BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/24234fe77718a553ccc6ffdea0f2ee3ef414e0b6

Patch Set 1 #

Patch Set 2 : fix sign #

Patch Set 3 : fix bench pictures #

Patch Set 4 : clean up macro usage in render_pictures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M include/gpu/GrConfig.h View 1 chunk +10 lines, -2 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 1 chunk +12 lines, -5 lines 0 comments Download
M tools/bench_pictures_main.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/render_pictures_main.cpp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
bsalomon
6 years, 2 months ago (2014-10-24 15:04:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655263005/20001
6 years, 2 months ago (2014-10-24 15:04:42 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-24 15:04:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/226)
6 years, 2 months ago (2014-10-24 15:06:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655263005/60001
6 years, 2 months ago (2014-10-24 15:29:51 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-24 15:29:52 UTC) #10
robertphillips
lgtm
6 years, 2 months ago (2014-10-24 15:34:57 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 16:34:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 24234fe77718a553ccc6ffdea0f2ee3ef414e0b6

Powered by Google App Engine
This is Rietveld 408576698