Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 655253006: Remove old WebSocket implementation from content/ (Closed)

Created:
6 years, 2 months ago by Adam Rice
Modified:
6 years, 2 months ago
Reviewers:
yhirano, nasko
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, mkwst+moarreviews-ipc_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove old WebSocket implementation from content/ Remove the old SocketStream-based WebSocket implementation from content/. Large parts of the implementation still exist in net/. They will be removed in a subsequent CL. There are also a few traces in chrome/, and some interfaces in Blink that cannot be removed until this CL is submitted. BUG=423201 TEST=layout tests, browser_tests Committed: https://crrev.com/8e60ab5d142eaa8c04a385f265f1c328ad5a9b6d Cr-Commit-Position: refs/heads/master@{#301075}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1375 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +0 lines, -11 lines 0 comments Download
D content/browser/renderer_host/socket_stream_dispatcher_host.h View 1 1 chunk +0 lines, -89 lines 0 comments Download
D content/browser/renderer_host/socket_stream_dispatcher_host.cc View 1 chunk +0 lines, -278 lines 0 comments Download
D content/browser/renderer_host/socket_stream_host.h View 1 1 chunk +0 lines, -79 lines 0 comments Download
D content/browser/renderer_host/socket_stream_host.cc View 1 1 chunk +0 lines, -110 lines 0 comments Download
M content/child/blink_platform_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 1 3 chunks +0 lines, -6 lines 0 comments Download
M content/child/child_thread.h View 1 3 chunks +0 lines, -8 lines 0 comments Download
M content/child/child_thread.cc View 1 3 chunks +0 lines, -4 lines 0 comments Download
D content/child/socket_stream_dispatcher.h View 1 1 chunk +0 lines, -51 lines 0 comments Download
D content/child/socket_stream_dispatcher.cc View 1 1 chunk +0 lines, -255 lines 0 comments Download
D content/child/web_socket_stream_handle_bridge.h View 1 chunk +0 lines, -37 lines 0 comments Download
D content/child/web_socket_stream_handle_delegate.h View 1 chunk +0 lines, -44 lines 0 comments Download
D content/child/web_socket_stream_handle_impl.h View 1 chunk +0 lines, -35 lines 0 comments Download
D content/child/web_socket_stream_handle_impl.cc View 1 1 chunk +0 lines, -194 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/socket_stream.h View 1 chunk +0 lines, -14 lines 0 comments Download
D content/common/socket_stream_handle_data.h View 1 1 chunk +0 lines, -30 lines 0 comments Download
D content/common/socket_stream_messages.h View 1 chunk +0 lines, -80 lines 0 comments Download
M content/common/websocket_messages.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_child.gypi View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M content/ppapi_plugin/ppapi_blink_platform_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_blink_platform_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 3 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download
M content/shell/browser/shell_network_delegate.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/browser/shell_network_delegate.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Adam Rice
6 years, 2 months ago (2014-10-21 13:46:32 UTC) #2
yhirano
lgtm
6 years, 2 months ago (2014-10-23 01:53:48 UTC) #3
Adam Rice
+nasko for content/
6 years, 2 months ago (2014-10-23 04:18:07 UTC) #5
nasko
Code removal is awesome! LGTM
6 years, 2 months ago (2014-10-23 17:20:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655253006/20001
6 years, 2 months ago (2014-10-24 07:41:31 UTC) #8
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
6 years, 2 months ago (2014-10-24 08:33:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655253006/20001
6 years, 2 months ago (2014-10-24 08:53:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-24 08:54:03 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 08:54:51 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e60ab5d142eaa8c04a385f265f1c328ad5a9b6d
Cr-Commit-Position: refs/heads/master@{#301075}

Powered by Google App Engine
This is Rietveld 408576698