Update intialization of vtune support.

Update intialization of vtune support.

 In R23940 (https://code.google.com/p/v8/source/detail?r=23940) it introduces
 Isolate::CreateParams and mentions that V8::SetJitCodeEventHandler should either
 be passed to Isolate::New as well, or invoked via the Isolate.

 When Chrome as embedder of V8, we will set the Jit Code event handler for Vtune
 support during the initialization of renderer process and V8 has be initialized
 at that time. It's better that we invoke V8::SetJitCodeEventHander via the Isolate.
 So we change the vTune::InitializeVtuneForV8(v8::Isolate::CreateParams& params) to
 vTune::InitializeVtuneForV8(v8::Isolate* isolate).

 we will do corresponding changes in chromium code if this patch is landed and Chromium
 updates V8 to the
 new release branch.

 some part of this patch is provided by denis.pravdin@intel.com.

BUG=
R=danno@chromium.org, jochen@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24811

[chunyang.dai, 2014-10-15 08:26:33]

chunyang.dai@intel.com changed reviewers:
+ danno@chromium.org, jochen@chromium.org

[chunyang.dai, 2014-10-15 08:27:34]

hello, Daniel & Jochen.

PTAL.

thanks.

[danno, 2014-10-15 08:52:48]

lgtm

[chunyang.dai, 2014-10-15 09:03:42]

Hello.
Please help to commit it.
Thanks

[jochen (gone - plz use gerrit), 2014-10-15 09:38:37]

note that you won't get jit events for all code jitted during deserialization of
the snapshot with this CL

[jochen (gone - plz use gerrit), 2014-10-15 09:39:18]

btw, chrome also has a way to set the jit code event handler before isolate
creation in gin/public/debug.h

[chunyang.dai, 2014-10-16 08:35:27]

hello, Jochen.
Thank you for your comments.  

Yes, This CL will lose some jit code create event if snapshot is switched off. 

According to your comments and my understanding, there are two other options for
vtune intialization:

   1, To invoke InitializeVtuneForV8(v8::Isolate::CreateParams& params) API in
constructor of IsolateHolder.
      ( in gin/isolate_holder.cc, line 53 ).  

      This will introduces more code changes in gin/DEP and gin/gin.gyp so that
vtune code can be linked
      during compilation.

   2, gin::Debug::SetJitCodeEventhandler(v8::JitCodeEventHandler event_handler)
is invoked to set vtune
      jit event handler and Vtune provides another API to provide the 
      vTune::internal::VTUNEJITInterface::event_handler as parameter of
gin::Debug::SetJitCodeEventhandler
      function. 


Which one is the best and acceptable option?

thanks,

[jochen (gone - plz use gerrit), 2014-10-17 11:55:17]

On 2014/10/16 at 08:35:27, chunyang.dai wrote:
> hello, Jochen.
> Thank you for your comments.  
> 
> Yes, This CL will lose some jit code create event if snapshot is switched off.

> 
> According to your comments and my understanding, there are two other options
for vtune intialization:
> 
>    1, To invoke InitializeVtuneForV8(v8::Isolate::CreateParams& params) API in
constructor of IsolateHolder.
>       ( in gin/isolate_holder.cc, line 53 ).  
> 
>       This will introduces more code changes in gin/DEP and gin/gin.gyp so
that vtune code can be linked
>       during compilation.
> 
>    2, gin::Debug::SetJitCodeEventhandler(v8::JitCodeEventHandler
event_handler) is invoked to set vtune
>       jit event handler and Vtune provides another API to provide the 
>       vTune::internal::VTUNEJITInterface::event_handler as parameter of
gin::Debug::SetJitCodeEventhandler
>       function. 
> 
> 
> Which one is the best and acceptable option?

I'd prefer (2)

[chunyang.dai, 2014-10-21 09:24:42]

hello, Jochen.
I updated the patch. PTAL.

And I created one CL for the corresponding code changes for chromium code.
https://codereview.chromium.org/666023003. Please give your suggestion.

Once the new code change of V8 is merged to chromium, I will ask the owner
of chromium code to review and commit that CL. Is that ok?

Thanks.

[jochen (gone - plz use gerrit), 2014-10-21 12:43:22]

https://codereview.chromium.org/655183002/diff/20001/src/third_party/vtune/v8...
File src/third_party/vtune/v8-vtune.h (right):

https://codereview.chromium.org/655183002/diff/20001/src/third_party/vtune/v8...
src/third_party/vtune/v8-vtune.h:66: v8::JitCodeEventHandler
GetVtuneCodeEventHandler();
can you change d8 to use this API as well so we only have one way to install the
jit code handler from vtune?

[chunyang.dai, 2014-10-22 02:03:31]

I modified it according to your comments.

Please review it. And please help to commit it if it's ok.
thanks.

[jochen (gone - plz use gerrit), 2014-10-22 15:26:12]

lgtm

[jochen (gone - plz use gerrit), 2014-10-22 15:31:01]

Committed patchset #3 (id:40001) manually as 24811 (presubmit successful).