Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 666023003: update the vtune support code. (Closed)

Created:
6 years, 2 months ago by chunyang.dai
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

update the vtune support code. The API for vtune support on V8 part changed. So we do this change. BUG= Committed: https://crrev.com/be874c5a46b87853f2ef2fcf50934bfdd6b7716e Cr-Commit-Position: refs/heads/master@{#304183}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -29 lines) Patch
M content/renderer/render_thread_impl.cc View 1 4 chunks +12 lines, -2 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_android.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_linux.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-21 12:43:14 UTC) #3
chunyang.dai
Hi, James. Please review this patch. thanks.
6 years, 1 month ago (2014-11-10 02:56:22 UTC) #5
jochen (gone - plz use gerrit)
I'm also an owner, you should be good to go
6 years, 1 month ago (2014-11-12 14:51:31 UTC) #6
chunyang.dai
Hello,Jochen. Could you please help to commit this patch? Thanks.
6 years, 1 month ago (2014-11-13 01:15:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666023003/1
6 years, 1 month ago (2014-11-13 15:18:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/33586) linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/10198) linux_chromium_chromeos_rel ...
6 years, 1 month ago (2014-11-13 15:22:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666023003/20001
6 years, 1 month ago (2014-11-14 05:53:48 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-14 06:45:13 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 06:46:14 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be874c5a46b87853f2ef2fcf50934bfdd6b7716e
Cr-Commit-Position: refs/heads/master@{#304183}

Powered by Google App Engine
This is Rietveld 408576698