Issue 655143003: Don't try to create extensionoptions for extensions that don't exist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 655143003: Don't try to create extensionoptions for extensions that don't exist. (Closed)

Created:
6 years, 2 months ago by not at google - send to devlin

Modified:
6 years, 2 months ago

Reviewers:
Marijn Kruisselbrink

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Don't try to create extensionoptions for extensions that don't exist. R=mek@chromium.org BUG=414526 Committed: https://crrev.com/94b43486b5ea8b8864686e298ed8f6b8131aae98 Cr-Commit-Position: refs/heads/master@{#300018}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -3 lines)			Patch
M	chrome/browser/extensions/extension_webui_apitest.cc	View	2 chunks	+27 lines, -1 line	0 comments	Download
M	chrome/browser/resources/extensions/extension_list.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/webui/can_embed_extension_options.js	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	extensions/browser/guest_view/extension_options/extension_options_guest.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655143003/1

6 years, 2 months ago (2014-10-16 21:44:31 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 00:05:24 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/94b43486b5ea8b8864686e298ed8f6b8131aae98
Cr-Commit-Position: refs/heads/master@{#300018}