chrome/test/data/extensions/webui/can_embed_extension_options.js - Issue 655143003: Don't try to create extensionoptions for extensions that don't exist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/webui/can_embed_extension_options.js

Issue 655143003: Don't try to create extensionoptions for extensions that don't exist. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/webui/can_embed_extension_options.js

diff --git a/chrome/test/data/extensions/webui/can_embed_extension_options.js b/chrome/test/data/extensions/webui/can_embed_extension_options.js

index 57f538dee8048bb0b3dca35b9a1719799fe6d1e6..a65e733d3f5f920aa019da29b0aee0f22e8646c6 100644

--- a/chrome/test/data/extensions/webui/can_embed_extension_options.js

+++ b/chrome/test/data/extensions/webui/can_embed_extension_options.js

@@ -4,6 +4,11 @@

// out/Debug/browser_tests

// --gtest_filter=ExtensionWebUITest.CanEmbedExtensionOptions

+//

+// also used by:

+//

+// out/Debug/browser_tests

+// --gtest_filter=ExtensionWebUITest.CannotEmbedDisabledExtension

if (!chrome || !chrome.test || !chrome.test.sendMessage) {

console.error('chrome.test.sendMessage is unavailable on ' +

document.location.href);

@@ -14,7 +19,10 @@ if (!chrome || !chrome.test || !chrome.test.sendMessage) {

chrome.test.sendMessage('ready', function(reply) {

var extensionoptions = document.createElement('extensionoptions');

extensionoptions.addEventListener('load', function() {

- chrome.test.sendMessage('guest loaded');

+ chrome.test.sendMessage('load');

+ });

+ extensionoptions.addEventListener('createfailed', function() {

+ chrome.test.sendMessage('createfailed');

});

extensionoptions.setAttribute('extension', reply);

document.body.appendChild(extensionoptions);