sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h - Issue 655083003: Remove GarbageCollectedFinalized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h

Issue 655083003: Remove GarbageCollectedFinalized (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h

diff --git a/sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h b/sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h

index cedda1946d62c5b3564eeffe28077ec7762fc02f..e05feea42d2e7fb1cd6feb1681ec9615d6490a83 100644

--- a/sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h

+++ b/sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h

@@ -20,7 +20,7 @@ class DOMWrapperWorld;

class ExecutionContext;

class ScriptState;

-class ScriptPromisePropertyBase : public GarbageCollectedFinalized<ScriptPromisePropertyBase>, public ContextLifecycleObserver {

+class ScriptPromisePropertyBase : public ContextLifecycleObserver {

public:

virtual ~ScriptPromisePropertyBase();