Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: sky/engine/bindings/core/v8/ScriptFunction.h

Issue 655083003: Remove GarbageCollectedFinalized (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/ScriptFunction.h
diff --git a/sky/engine/bindings/core/v8/ScriptFunction.h b/sky/engine/bindings/core/v8/ScriptFunction.h
index 9a48454f51e63cfeac03a68b1e967fd91feaf488..beca7a28a0b6f024958ff32b10a02afda9a49c5b 100644
--- a/sky/engine/bindings/core/v8/ScriptFunction.h
+++ b/sky/engine/bindings/core/v8/ScriptFunction.h
@@ -49,11 +49,10 @@ namespace blink {
// return self->bindToV8Function();
// }
// };
-class ScriptFunction : public GarbageCollectedFinalized<ScriptFunction> {
+class ScriptFunction {
public:
virtual ~ScriptFunction() { }
ScriptState* scriptState() const { return m_scriptState.get(); }
- virtual void trace(Visitor*) { }
protected:
explicit ScriptFunction(ScriptState* scriptState)
« no previous file with comments | « no previous file | sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698