Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 655083003: Remove GarbageCollectedFinalized (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove GarbageCollectedFinalized This class didn't actually do anything anymore. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4b5d0f5b187348f4ccceed2be0eb9205da5da01c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -322 lines) Patch
M sky/engine/bindings/core/v8/ScriptFunction.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/templates/dictionary_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/bindings/templates/dictionary_impl.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/css/FontFaceSet.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/dom/ElementData.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/dom/Node.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/platform/heap/Handle.h View 3 chunks +0 lines, -100 lines 0 comments Download
M sky/engine/platform/heap/Heap.h View 3 chunks +0 lines, -131 lines 0 comments Download
M sky/engine/public/platform/WebPrivatePtr.h View 2 chunks +2 lines, -62 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
6 years, 1 month ago (2014-10-28 00:36:16 UTC) #1
abarth-chromium
lgtm
6 years, 1 month ago (2014-10-28 00:36:27 UTC) #2
eseidel
6 years, 1 month ago (2014-10-28 00:41:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4b5d0f5b187348f4ccceed2be0eb9205da5da01c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698