Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: remoting/protocol/network_settings_unittest.cc

Issue 655063002: Use uint16 for port numbers more pervasively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert bad change Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/network_settings_unittest.cc
diff --git a/remoting/protocol/network_settings_unittest.cc b/remoting/protocol/network_settings_unittest.cc
index c62c51bf6ee12dbd5d7ff3c92dc19ecb452e71ab..398d5593909a631a3a7dc801c21d367389d4ab68 100644
--- a/remoting/protocol/network_settings_unittest.cc
+++ b/remoting/protocol/network_settings_unittest.cc
@@ -10,20 +10,20 @@ namespace remoting {
namespace protocol {
TEST(ParsePortRange, Basic) {
- int min, max;
+ uint16 min, max;
// Valid range
EXPECT_TRUE(NetworkSettings::ParsePortRange("1-65535", &min, &max));
- EXPECT_EQ(1, min);
- EXPECT_EQ(65535, max);
+ EXPECT_EQ(1u, min);
+ EXPECT_EQ(65535u, max);
EXPECT_TRUE(NetworkSettings::ParsePortRange(" 1 - 65535 ", &min, &max));
- EXPECT_EQ(1, min);
- EXPECT_EQ(65535, max);
+ EXPECT_EQ(1u, min);
+ EXPECT_EQ(65535u, max);
EXPECT_TRUE(NetworkSettings::ParsePortRange("12400-12400", &min, &max));
- EXPECT_EQ(12400, min);
- EXPECT_EQ(12400, max);
+ EXPECT_EQ(12400u, min);
+ EXPECT_EQ(12400u, max);
// Invalid
EXPECT_FALSE(NetworkSettings::ParsePortRange("", &min, &max));
« no previous file with comments | « remoting/protocol/network_settings.cc ('k') | sync/internal_api/attachments/attachment_uploader_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698