Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: remoting/protocol/network_settings.cc

Issue 655063002: Use uint16 for port numbers more pervasively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert bad change Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/network_settings.h ('k') | remoting/protocol/network_settings_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/network_settings.cc
diff --git a/remoting/protocol/network_settings.cc b/remoting/protocol/network_settings.cc
index 67db2679404474e3f39c8a3b01c1d1efeca5207f..65068ef951197ce2f76e28c896025f23f6200a0e 100644
--- a/remoting/protocol/network_settings.cc
+++ b/remoting/protocol/network_settings.cc
@@ -15,8 +15,8 @@ namespace protocol {
// static
bool NetworkSettings::ParsePortRange(const std::string& port_range,
- int* out_min_port,
- int* out_max_port) {
+ uint16* out_min_port,
+ uint16* out_max_port) {
size_t separator_index = port_range.find('-');
if (separator_index == std::string::npos)
return false;
@@ -38,8 +38,8 @@ namespace protocol {
if (min_port == 0 || min_port > max_port || max_port > USHRT_MAX)
return false;
- *out_min_port = static_cast<int>(min_port);
- *out_max_port = static_cast<int>(max_port);
+ *out_min_port = static_cast<uint16>(min_port);
+ *out_max_port = static_cast<uint16>(max_port);
return true;
}
« no previous file with comments | « remoting/protocol/network_settings.h ('k') | remoting/protocol/network_settings_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698