content/browser/devtools/protocol/tethering_handler.h - Issue 655063002: Use uint16 for port numbers more pervasively.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/tethering_handler.h

Issue 655063002: Use uint16 for port numbers more pervasively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert bad change Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/tethering_handler.h

diff --git a/content/browser/devtools/protocol/tethering_handler.h b/content/browser/devtools/protocol/tethering_handler.h

index a1b808217258549e300ed752f49d598f4150421f..89467c9dd3cc4604f92d8c9c7e4e8e17667e7800 100644

--- a/content/browser/devtools/protocol/tethering_handler.h

+++ b/content/browser/devtools/protocol/tethering_handler.h

@@ -26,14 +26,14 @@ class TetheringHandler {

void SetClient(scoped_ptr<Client> client);

scoped_refptr<DevToolsProtocol::Response> Bind(

- int port, scoped_refptr<DevToolsProtocol::Command> command);

+ uint16 port, scoped_refptr<DevToolsProtocol::Command> command);

scoped_refptr<DevToolsProtocol::Response> Unbind(

- int port, scoped_refptr<DevToolsProtocol::Command> command);

+ uint16 port, scoped_refptr<DevToolsProtocol::Command> command);

private:

class TetheringImpl;

- void Accepted(int port, const std::string& name);

+ void Accepted(uint16 port, const std::string& name);

bool Activate();

void SendBindSuccess(scoped_refptr<DevToolsProtocol::Command> command);