Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: content/browser/devtools/devtools_http_handler_unittest.cc

Issue 655063002: Use uint16 for port numbers more pervasively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert bad change Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler_unittest.cc
diff --git a/content/browser/devtools/devtools_http_handler_unittest.cc b/content/browser/devtools/devtools_http_handler_unittest.cc
index 8dd8ce862518111cbe5764a17f6de250b45e73d9..6800c3cc34559e3e1731cbcf76a401427e43a3f9 100644
--- a/content/browser/devtools/devtools_http_handler_unittest.cc
+++ b/content/browser/devtools/devtools_http_handler_unittest.cc
@@ -20,7 +20,7 @@
namespace content {
namespace {
-const int kDummyPort = 4321;
+const uint16 kDummyPort = 4321;
const base::FilePath::CharType kDevToolsActivePortFileName[] =
FILE_PATH_LITERAL("DevToolsActivePort");
@@ -34,7 +34,7 @@ class DummyServerSocket : public net::ServerSocket {
}
int ListenWithAddressAndPort(const std::string& ip_address,
- int port,
+ uint16 port,
int backlog) override {
return net::OK;
}
@@ -201,7 +201,7 @@ TEST_F(DevToolsHttpHandlerTest, TestDevToolsActivePort) {
EXPECT_TRUE(base::ReadFileToString(active_port_file, &file_contents));
int port = 0;
EXPECT_TRUE(base::StringToInt(file_contents, &port));
- EXPECT_EQ(kDummyPort, port);
+ EXPECT_EQ(static_cast<int>(kDummyPort), port);
}
} // namespace content
« no previous file with comments | « content/browser/devtools/devtools_http_handler_impl.cc ('k') | content/browser/devtools/protocol/tethering_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698