Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 655001: Allow building without SVG. (Closed)

Created:
10 years, 10 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai, jorlow
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Allow building without SVG. Only useful for debug builds, obviously. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M build/features_override.gypi View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
I guess this will commit ok, it just won't be useful until my upstream wk ...
10 years, 10 months ago (2010-02-23 15:48:42 UTC) #1
jorlow
Seems reasonable...but I'm not sure I'm the best reviewer. LGTM if you're confident tho.
10 years, 10 months ago (2010-02-23 15:55:47 UTC) #2
Evan Martin
I must admit the gyp bits are kind of black magic to me, so I ...
10 years, 10 months ago (2010-02-23 15:58:10 UTC) #3
Mark Mentovai
10 years, 10 months ago (2010-02-23 16:06:08 UTC) #4
LGTM.  The existing comment here doesn't do the best job of explaining the black
magic.

Powered by Google App Engine
This is Rietveld 408576698