Source/web/FrameLoaderClientImpl.h - Issue 654953002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.h

Issue 654953002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: re-add TypeChecking Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.h

diff --git a/Source/web/FrameLoaderClientImpl.h b/Source/web/FrameLoaderClientImpl.h

index c91528126c54354c063a5642b2e574b1160628a8..1d0d8c1e2b7e7bf386da9cf11347899405facddb 100644

--- a/Source/web/FrameLoaderClientImpl.h

+++ b/Source/web/FrameLoaderClientImpl.h

@@ -96,7 +96,10 @@ public:

virtual void dispatchDidChangeThemeColor() override;

virtual NavigationPolicy decidePolicyForNavigation(const ResourceRequest&, DocumentLoader*, NavigationPolicy, bool isTransitionNavigation) override;

- virtual void dispatchAddNavigationTransitionData(const String& allowedDestinationOrigin, const String& selector, const String& markup) override;

+ virtual void dispatchAddNavigationTransitionData(

sof 2014/10/24 15:17:14 Stick with the Blink coding style of keeping it al

Zhen Wang 2014/10/27 14:14:45 Using struct now.

+ const String& allowedDestinationOrigin, const String& selector,

+ const String& markup, const Vector<String>& names,

+ const Vector<IntRect>& rects) override;

virtual void dispatchWillRequestResource(FetchRequest*) override;

virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) override;

virtual void dispatchWillSubmitForm(HTMLFormElement*) override;

« Source/core/testing/Internals.cpp ('K') | « Source/core/testing/Internals.idl ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | Source/web/FrameLoaderClientImpl.cpp » ('J')