Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

Source/core/testing/Internals.cpp

Index: Source/core/testing/Internals.cpp
diff --git a/Source/core/testing/Internals.cpp b/Source/core/testing/Internals.cpp
index b98434a4f89d5d3944e552b9fe5c4b9236ed41e7..904fe74adca56cf2fd87cb5e69480a2e1282367f 100644
--- a/Source/core/testing/Internals.cpp
+++ b/Source/core/testing/Internals.cpp
@@ -2244,6 +2244,12 @@ unsigned Internals::countHitRegions(CanvasRenderingContext2D* context)
     return context->hitRegionsCount();
 }
 
+PassRefPtrWillBeRawPtr<ClientRect> Internals::boundsInRootViewSpace(Element* element)
+{
+    ASSERT(element);
+    return ClientRect::create(element->boundsInRootViewSpace());
+}
+
 String Internals::serializeNavigationMarkup()
 {
     Vector<Document::TransitionElementData> elementData;
@@ -2257,6 +2263,41 @@ String Internals::serializeNavigationMarkup()
     return markup.toString();
 }
 
+Vector<String> Internals::getTransitionElementNames()
+{
+    Vector<Document::TransitionElementData> elementData;
+    frame()->document()->getTransitionElementData(elementData);
+
+    Vector<String> names;
+    Vector<Document::TransitionElementData>::iterator iter = elementData.begin();

[sof, 2014/10/24 15:17:14]

Shorter as (the untested)

  for (const auto& element : elementData)
      names.appendVector(element.names);

[Zhen Wang, 2014/10/27 14:14:45]

I see other for loops using the traditional version. Any strong reason for the
shorter version?

+    for (; iter != elementData.end(); ++iter) {
+        Vector<String>::iterator jter = iter->names.begin();
+        for (; jter != iter->names.end(); ++jter)
+            names.append(*jter);
+    }
+
+    return names;
+}
+
+PassRefPtrWillBeRawPtr<ClientRectList> Internals::getTransitionElementRects()
+{
+    Vector<Document::TransitionElementData> elementData;
+    frame()->document()->getTransitionElementData(elementData);
+
+    Vector<IntRect> rects;
+    Vector<Document::TransitionElementData>::iterator iter = elementData.begin();

[sof, 2014/10/24 15:17:14]

Can also be shortened.

[Zhen Wang, 2014/10/27 14:14:45]

ditto

+    for (; iter != elementData.end(); ++iter) {
+        Vector<IntRect>::iterator jter = iter->rects.begin();
+        for (; jter != iter->rects.end(); ++jter)
+            rects.append(*jter);
+    }
+
+    Vector<FloatQuad> quads(rects.size());
+    for (size_t i = 0; i < rects.size(); ++i)
+        quads[i] = FloatRect(rects[i]);
+    return ClientRectList::create(quads);
+}
+
 void Internals::hideAllTransitionElements()
 {
     Vector<Document::TransitionElementData> elementData;