Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

Source/core/testing/Internals.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 2226 matching lines @@
         return;
     }
     networkStateNotifier().setWebConnectionTypeForTest(webtype);
 }
 
 unsigned Internals::countHitRegions(CanvasRenderingContext2D* context)
 {
     return context->hitRegionsCount();
 }
 
+PassRefPtrWillBeRawPtr<ClientRect> Internals::boundsInRootViewSpace(Element* element)
+{
+    ASSERT(element);
+    return ClientRect::create(element->boundsInRootViewSpace());
+}
+
 String Internals::serializeNavigationMarkup()
 {
     Vector<Document::TransitionElementData> elementData;
     frame()->document()->getTransitionElementData(elementData);
 
     StringBuilder markup;
     Vector<Document::TransitionElementData>::iterator iter = elementData.begin();
     for (; iter != elementData.end(); ++iter)
         markup.append(iter->markup);
 
     return markup.toString();
 }
 
+Vector<String> Internals::getTransitionElementNames()
+{
+    Vector<Document::TransitionElementData> elementData;
+    frame()->document()->getTransitionElementData(elementData);
+
+    Vector<String> names;
+    Vector<Document::TransitionElementData>::iterator iter = elementData.begin();

[sof, 2014/10/24 15:17:14]

Shorter as (the untested)

  for (const auto& element : elementData)
      names.appendVector(element.names);

[Zhen Wang, 2014/10/27 14:14:45]

I see other for loops using the traditional version. Any strong reason for the
shorter version?

+    for (; iter != elementData.end(); ++iter) {
+        Vector<String>::iterator jter = iter->names.begin();
+        for (; jter != iter->names.end(); ++jter)
+            names.append(*jter);
+    }
+
+    return names;
+}
+
+PassRefPtrWillBeRawPtr<ClientRectList> Internals::getTransitionElementRects()
+{
+    Vector<Document::TransitionElementData> elementData;
+    frame()->document()->getTransitionElementData(elementData);
+
+    Vector<IntRect> rects;
+    Vector<Document::TransitionElementData>::iterator iter = elementData.begin();

[sof, 2014/10/24 15:17:14]

Can also be shortened.

[Zhen Wang, 2014/10/27 14:14:45]

ditto

+    for (; iter != elementData.end(); ++iter) {
+        Vector<IntRect>::iterator jter = iter->rects.begin();
+        for (; jter != iter->rects.end(); ++jter)
+            rects.append(*jter);
+    }
+
+    Vector<FloatQuad> quads(rects.size());
+    for (size_t i = 0; i < rects.size(); ++i)
+        quads[i] = FloatRect(rects[i]);
+    return ClientRectList::create(quads);
+}
+
 void Internals::hideAllTransitionElements()
 {
     Vector<Document::TransitionElementData> elementData;
     frame()->document()->getTransitionElementData(elementData);
 
     Vector<Document::TransitionElementData>::iterator iter = elementData.begin();
     for (; iter != elementData.end(); ++iter)
         frame()->document()->hideTransitionElements(AtomicString(iter->selector));
 }
 
@@ skipping 14 matching lines @@
     }
     toHTMLPlugInElement(element)->setPlaceholder(DictionaryPluginPlaceholder::create(element->document(), options));
 }
 
 Iterator* Internals::iterator(ScriptState* scriptState, ExceptionState& exceptionState)
 {
     return new InternalsIterator;
 }
 
 } // namespace blink