Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

Source/web/FrameLoaderClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 460 matching lines @@
     navigationInfo.extraData = ds->extraData();
     navigationInfo.navigationType = ds->navigationType();
     navigationInfo.defaultPolicy = static_cast<WebNavigationPolicy>(policy);
     navigationInfo.isRedirect = ds->isRedirect();
     navigationInfo.isTransitionNavigation = isTransitionNavigation;
 
     WebNavigationPolicy webPolicy = m_webFrame->client()->decidePolicyForNavigation(navigationInfo);
     return static_cast<NavigationPolicy>(webPolicy);
 }
 
-void FrameLoaderClientImpl::dispatchAddNavigationTransitionData(const String& allowedDestinationOrigin, const String& selector, const String& markup)
+void FrameLoaderClientImpl::dispatchAddNavigationTransitionData(
+    const String& allowedDestinationOrigin, const String& selector,
+    const String& markup, const Vector<String>& names,

[esprehn, 2014/10/21 20:50:49]

pass a struct instead of a long list of args.

[Zhen Wang, 2014/10/21 21:36:48]

Currently the implementation uses this interface. See:
https://codereview.chromium.org/652283002/diff/60001/content/renderer/render_...
(committed yesterday. not yet in online code search.)


Do you mean I should create something like WebTransitionElementData and pass the
data to content side?

+    const Vector<IntRect>& rects)
 {
-    if (m_webFrame->client())
-        m_webFrame->client()->addNavigationTransitionData(allowedDestinationOrigin, selector, markup);
+    if (m_webFrame->client()) {
+        m_webFrame->client()->addNavigationTransitionData(
+            allowedDestinationOrigin, selector, markup, names, rects);
+    }
 }
 
 void FrameLoaderClientImpl::dispatchWillRequestResource(FetchRequest* request)
 {
     if (m_webFrame->client()) {
         WebCachedURLRequest urlRequest(request);
         m_webFrame->client()->willRequestResource(m_webFrame, urlRequest);
     }
 }
 
@@ skipping 358 matching lines @@
         m_webFrame->client()->didAbortLoading(m_webFrame);
 }
 
 void FrameLoaderClientImpl::dispatchDidChangeManifest()
 {
     if (m_webFrame->client())
         m_webFrame->client()->didChangeManifest(m_webFrame);
 }
 
 } // namespace blink