Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

Source/core/loader/FrameLoader.cpp

Index: Source/core/loader/FrameLoader.cpp
diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp
index a1583c411d1ef3f840e7714411e2f05d0f7891e9..10e9fe73261399f633e2a52a7d8b5f543a1fc1b5 100644
--- a/Source/core/loader/FrameLoader.cpp
+++ b/Source/core/loader/FrameLoader.cpp
@@ -1238,7 +1238,7 @@ bool FrameLoader::dispatchNavigationTransitionData()
 
     Vector<Document::TransitionElementData>::iterator iter = elementData.begin();
     for (; iter != elementData.end(); ++iter)
-        client()->dispatchAddNavigationTransitionData(iter->scope, iter->selector, iter->markup);
+        client()->dispatchAddNavigationTransitionData(iter->scope, iter->selector, iter->markup, iter->names, iter->rects);

[esprehn, 2014/10/21 20:50:48]

Seems like you should be passing a struct, passing a super long list of stuff
from the iter seems strange. Why not just pass the TransitionElementData?

[Zhen Wang, 2014/10/21 21:36:48]

ditto. See FrameLoaderClientImpl.cpp

 
     return true;
 }