Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

Source/core/dom/Document.cpp

Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index f86165bfacaabc8a39926d87b6606b118913880a..eac135b5009c02f8c21a817ef791c23122eef9ae 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -60,6 +60,7 @@
 #include "core/dom/AddConsoleMessageTask.h"
 #include "core/dom/Attr.h"
 #include "core/dom/CDATASection.h"
+#include "core/dom/ClientRect.h"
 #include "core/dom/Comment.h"
 #include "core/dom/ContextFeatures.h"
 #include "core/dom/DOMImplementation.h"
@@ -5645,13 +5646,15 @@ void Document::getTransitionElementData(Vector<TransitionElementData>& elementDa
         if (!nodeListLength)
             continue;
 
+        TransitionElementData newElements;
         StringBuilder markup;
         for (unsigned nodeIndex = 0; nodeIndex < nodeListLength; ++nodeIndex) {
             Element* element = elementList->item(nodeIndex);
             markup.append(createStyledMarkupForNavigationTransition(element));
+            newElements.rects.append(element->boundsInRootViewSpace());
+            newElements.names.append(element->getIdAttribute().string());

[esprehn, 2014/10/21 20:50:48]

These elements don't have to have ids, you just select them with querySelector.

[Zhen Wang, 2014/10/21 21:36:47]

These elements are from the elementList, which are from querySelectorAll(). See
line 5641. So they have ids.

         }
 
-        TransitionElementData newElements;
         newElements.scope = metaElementContents.substring(firstSemicolon + 1).stripWhiteSpace();
         newElements.selector = selector;
         newElements.markup = markup.toString();