Source/core/loader/FrameLoaderClient.h - Issue 654953002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoaderClient.h

Issue 654953002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review fix Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/FrameLoaderClient.h

diff --git a/Source/core/loader/FrameLoaderClient.h b/Source/core/loader/FrameLoaderClient.h

index 895175bf7b1904d64bb511411f8f87a97f6cd14f..aa882d5dad30189066c83c5bc5f4b5719b5379e0 100644

--- a/Source/core/loader/FrameLoaderClient.h

+++ b/Source/core/loader/FrameLoaderClient.h

@@ -30,6 +30,7 @@

#ifndef FrameLoaderClient_h

#define FrameLoaderClient_h

+#include "core/dom/Document.h"

#include "core/dom/IconURL.h"

#include "core/frame/FrameClient.h"

#include "core/loader/FrameLoaderTypes.h"

@@ -99,7 +100,7 @@ namespace blink {

virtual NavigationPolicy decidePolicyForNavigation(const ResourceRequest&, DocumentLoader*, NavigationPolicy, bool isTransitionNavigation) = 0;

- virtual void dispatchAddNavigationTransitionData(const String& origin, const String& selector, const String& markup) { }

+ virtual void dispatchAddNavigationTransitionData(const Document::TransitionElementData&) { }

virtual void dispatchWillRequestResource(FetchRequest*) { }

virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) = 0;

« no previous file with comments | « Source/core/loader/FrameLoader.cpp ('k') | Source/core/testing/Internals.h » ('j') | Source/web/FrameLoaderClientImpl.cpp » ('J')