Source/core/loader/FrameLoader.cpp - Issue 654953002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 654953002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review fix Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/FrameLoader.cpp

diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp

index 640d69af701d16bc320672cf21b3a4f62ee28c19..eb32b820687e78b3e172c5ab8af1186fbd453bf5 100644

--- a/Source/core/loader/FrameLoader.cpp

+++ b/Source/core/loader/FrameLoader.cpp

@@ -1238,7 +1238,7 @@ bool FrameLoader::dispatchNavigationTransitionData()

Vector<Document::TransitionElementData>::iterator iter = elementData.begin();

for (; iter != elementData.end(); ++iter)

- client()->dispatchAddNavigationTransitionData(iter->scope, iter->selector, iter->markup);

+ client()->dispatchAddNavigationTransitionData(*iter);

return true;

}

« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/loader/FrameLoaderClient.h » ('j') | Source/web/FrameLoaderClientImpl.cpp » ('J')