Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

public/web/WebFrameClient.h

Index: public/web/WebFrameClient.h
diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h
index 17e7770b70bf3fa18b29158ec3d24353233ff509..25b35e3988597282f8d7f8b917930b9f3f1c085d 100644
--- a/public/web/WebFrameClient.h
+++ b/public/web/WebFrameClient.h
@@ -96,6 +96,7 @@ struct WebPluginParams;
 struct WebPopupMenuInfo;
 struct WebRect;
 struct WebSize;
+struct WebTransitionElementData;
 struct WebURLError;
 
 class WebFrameClient {
@@ -313,7 +314,11 @@ public:
     // Transition navigations -----------------------------------------------
 
     // Provides serialized markup of transition elements for use in the following navigation.
+    virtual void addNavigationTransitionData(const WebTransitionElementData&) { }
+
+    // TODO(zhenw): remove the following two addNavigationTransitionData() functions after the chrome side is done.

[Nate Chapin, 2014/11/05 18:29:43]

TODO->FIXME

[Zhen Wang, 2014/11/06 17:59:26]

Done.

     virtual void addNavigationTransitionData(const WebString& allowedDestinationOrigin, const WebString& selector, const WebString& markup) { }
+    virtual void addNavigationTransitionData(const WebString& allowedDestinationOrigin, const WebString& selector, const WebString& markup, const WebVector<WebString>& names, const WebVector<WebRect>& rects) { }

[Nate Chapin, 2014/11/05 18:29:43]

Is this intermediate api actually necessary?

[Zhen Wang, 2014/11/06 17:59:26]

In theory, not necessary. But in reality, we need it to pass compilation.

Currently in render_frame_impl, we have two implementations:

1. addNavigationTransitionData(WebString&, WebString&, WebString&)
2. addNavigationTransitionData(WebString&, WebString&, WebString&, WebVector&,
WebVector&)

If I remove this intermediate api and leave 2 function declarations here, the
compiler will complain that there is no matching member function. It cannot map
the declarations with WebTransitionElementData struct to the implementation.

If I keep this intermediate api, the compiler will understand that 2 functions
are implemented, and the one with WebTransitionElementData is not implemented.
And then the compilation can pass.

[Nate Chapin, 2014/11/11 00:28:17]

Huh, that seems strange, but I guess it's OK. So long as we get rid of it as
quickly as possible.

 
 
     // Web Notifications ---------------------------------------------------