Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

public/web/WebFrameClient.h

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 78 matching lines @@
 class WebURLResponse;
 class WebUserMediaClient;
 class WebWorkerPermissionClientProxy;
 struct WebColorSuggestion;
 struct WebConsoleMessage;
 struct WebContextMenuData;
 struct WebPluginParams;
 struct WebPopupMenuInfo;
 struct WebRect;
 struct WebSize;
+struct WebTransitionElementData;
 struct WebURLError;
 
 class WebFrameClient {
 public:
     // Factory methods -----------------------------------------------------
 
     // May return null.
     virtual WebPluginPlaceholder* createPluginPlaceholder(WebLocalFrame*, const WebPluginParams&) { return 0; }
 
     // May return null.
@@ skipping 197 matching lines @@
     // The frame's manifest has changed.
     virtual void didChangeManifest(WebLocalFrame*) { }
 
     // The frame's theme color has changed.
     virtual void didChangeThemeColor() { }
 
 
     // Transition navigations -----------------------------------------------
 
     // Provides serialized markup of transition elements for use in the following navigation.
+    virtual void addNavigationTransitionData(const WebTransitionElementData&) { }
+
+    // TODO(zhenw): remove the following two addNavigationTransitionData() functions after the chrome side is done.

[Nate Chapin, 2014/11/05 18:29:43]

TODO->FIXME

[Zhen Wang, 2014/11/06 17:59:26]

Done.

     virtual void addNavigationTransitionData(const WebString& allowedDestinationOrigin, const WebString& selector, const WebString& markup) { }
+    virtual void addNavigationTransitionData(const WebString& allowedDestinationOrigin, const WebString& selector, const WebString& markup, const WebVector<WebString>& names, const WebVector<WebRect>& rects) { }

[Nate Chapin, 2014/11/05 18:29:43]

Is this intermediate api actually necessary?

[Zhen Wang, 2014/11/06 17:59:26]

In theory, not necessary. But in reality, we need it to pass compilation.

Currently in render_frame_impl, we have two implementations:

1. addNavigationTransitionData(WebString&, WebString&, WebString&)
2. addNavigationTransitionData(WebString&, WebString&, WebString&, WebVector&,
WebVector&)

If I remove this intermediate api and leave 2 function declarations here, the
compiler will complain that there is no matching member function. It cannot map
the declarations with WebTransitionElementData struct to the implementation.

If I keep this intermediate api, the compiler will understand that 2 functions
are implemented, and the one with WebTransitionElementData is not implemented.
And then the compilation can pass.

[Nate Chapin, 2014/11/11 00:28:17]

Huh, that seems strange, but I guess it's OK. So long as we get rid of it as
quickly as possible.

 
 
     // Web Notifications ---------------------------------------------------
 
     // Requests permission to display platform notifications on the origin of this frame.
     virtual void requestNotificationPermission(const WebSecurityOrigin&, WebNotificationPermissionCallback* callback) { }
 
     // Called to retrieve the provider of desktop notifications.
     // FIXME: Remove this method once the presenter is obtained through Platform.
     virtual WebNotificationPresenter* notificationPresenter() { return 0; }
@@ skipping 245 matching lines @@
     // ServiceWorker.
     virtual bool isControlledByServiceWorker(WebDataSource&) { return false; }
 
 protected:
     virtual ~WebFrameClient() { }
 };
 
 } // namespace blink
 
 #endif