util/mach/exc_client_variants_test.cc - Issue 654933002: Use exactly one of final, override, and virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/mach/exc_client_variants_test.cc

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/mach/exc_client_variants_test.cc

diff --git a/util/mach/exc_client_variants_test.cc b/util/mach/exc_client_variants_test.cc

index 82e6363d1a63dbe4ee4752da4dfc99ef816e516c..2b1c6324abd7cc0438d3807d4bc2d3d7867654e5 100644

--- a/util/mach/exc_client_variants_test.cc

+++ b/util/mach/exc_client_variants_test.cc

@@ -133,7 +133,7 @@ class TestExcClientVariants : public UniversalMachExcServer,

private:

// MachMultiprocess:

- virtual void MachMultiprocessParent() override {

+ void MachMultiprocessParent() override {

kern_return_t kr = MachMessageServer::Run(this,

LocalPort(),

MACH_MSG_OPTION_NONE,

@@ -146,7 +146,7 @@ class TestExcClientVariants : public UniversalMachExcServer,

EXPECT_TRUE(handled_);

}

- virtual void MachMultiprocessChild() override {

+ void MachMultiprocessChild() override {

const exception_type_t exception = exception_;

const mach_exception_data_type_t code[] = {

exception_code_,

« no previous file with comments | « util/file/string_file_writer.h ('k') | util/mach/exc_server_variants.h » ('j') | no next file with comments »