snapshot/system_snapshot_mac_test.cc - Issue 654933002: Use exactly one of final, override, and virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/system_snapshot_mac_test.cc

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: snapshot/system_snapshot_mac_test.cc

diff --git a/snapshot/system_snapshot_mac_test.cc b/snapshot/system_snapshot_mac_test.cc

index bce1137d4efac06906317dff4fc869122be57c39..bc910aa83e833b87c315c8c5caa48db43e2dea73 100644

--- a/snapshot/system_snapshot_mac_test.cc

+++ b/snapshot/system_snapshot_mac_test.cc

@@ -48,7 +48,7 @@ class SystemSnapshotMacTest : public testing::Test {

}

// testing::Test:

- virtual void SetUp() override {

+ void SetUp() override {

ASSERT_TRUE(process_reader_.Initialize(mach_task_self()));

ASSERT_EQ(0, gettimeofday(&snapshot_time_, NULL))

<< ErrnoMessage("gettimeofday");

« no previous file with comments | « snapshot/system_snapshot_mac.h ('k') | snapshot/thread_snapshot_mac.h » ('j') | no next file with comments »