Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: minidump/minidump_memory_writer.h

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_file_writer_test.cc ('k') | minidump/minidump_memory_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_memory_writer.h
diff --git a/minidump/minidump_memory_writer.h b/minidump/minidump_memory_writer.h
index 555915bc0d8ebb4a688ba0fca60d4b7f324ad5f4..0f3c509c13cba815967e9cd38394685f0bba4f6b 100644
--- a/minidump/minidump_memory_writer.h
+++ b/minidump/minidump_memory_writer.h
@@ -75,8 +75,8 @@ class MinidumpMemoryWriter : public internal::MinidumpWritable {
virtual size_t MemoryRangeSize() const = 0;
// MinidumpWritable:
- virtual bool Freeze() override;
- virtual size_t SizeOfObject() override final;
+ bool Freeze() override;
+ size_t SizeOfObject() final;
//! \brief Returns the object’s desired byte-boundary alignment.
//!
@@ -87,9 +87,9 @@ class MinidumpMemoryWriter : public internal::MinidumpWritable {
//! \return `16`.
//!
//! \note Valid in #kStateFrozen or any subsequent state.
- virtual size_t Alignment() override;
+ size_t Alignment() override;
- virtual bool WillWriteAtOffsetImpl(off_t offset) override;
+ bool WillWriteAtOffsetImpl(off_t offset) override;
//! \brief Returns the object’s desired write phase.
//!
@@ -100,7 +100,7 @@ class MinidumpMemoryWriter : public internal::MinidumpWritable {
//! \return #kPhaseLate.
//!
//! \note Valid in any state.
- virtual Phase WritePhase() override final;
+ Phase WritePhase() final;
private:
MINIDUMP_MEMORY_DESCRIPTOR memory_descriptor_;
@@ -144,13 +144,13 @@ class MinidumpMemoryListWriter final : public internal::MinidumpStreamWriter {
protected:
// MinidumpWritable:
- virtual bool Freeze() override;
- virtual size_t SizeOfObject() override;
- virtual std::vector<MinidumpWritable*> Children() override;
- virtual bool WriteObject(FileWriterInterface* file_writer) override;
+ bool Freeze() override;
+ size_t SizeOfObject() override;
+ std::vector<MinidumpWritable*> Children() override;
+ bool WriteObject(FileWriterInterface* file_writer) override;
// MinidumpStreamWriter:
- virtual MinidumpStreamType StreamType() const override;
+ MinidumpStreamType StreamType() const override;
private:
MINIDUMP_MEMORY_LIST memory_list_base_;
« no previous file with comments | « minidump/minidump_file_writer_test.cc ('k') | minidump/minidump_memory_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698