Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 65493006: Remove a WebVTT newlines test that doesn't do what it says (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, feature-media-reviews_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove a WebVTT newlines test that doesn't do what it says tc003-newlines.vtt had CR line endings, not mixed as the test claimed. Mixed line endings are sufficiently covered by media/track/opera/track/webvtt/parsing/support/newlines.vtt BUG=318734 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162024

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -28 lines) Patch
D LayoutTests/media/track/captions-webvtt/tc003-newlines.vtt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/media/track/track-webvtt-tc003-newlines.html View 2 chunks +7 lines, -19 lines 0 comments Download
M LayoutTests/media/track/track-webvtt-tc003-newlines-expected.txt View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
I don't think I'll be able to get the tc003-no-newline-at-eof.vtt change through CQ, in which ...
7 years, 1 month ago (2013-11-13 21:13:27 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-14 12:15:06 UTC) #2
philipj_slow
Committed patchset #1 manually as r162014 (presubmit successful).
7 years, 1 month ago (2013-11-14 13:00:54 UTC) #3
philipj_slow
On 2013/11/14 13:00:54, philipj wrote: > Committed patchset #1 manually as r162014 (presubmit successful). I ...
7 years, 1 month ago (2013-11-14 13:01:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/65493006/80001
7 years, 1 month ago (2013-11-14 13:09:19 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 14:13:27 UTC) #6
Message was sent while issue was closed.
Change committed as 162024

Powered by Google App Engine
This is Rietveld 408576698